Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per Resource metrics #516

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Per Resource metrics #516

merged 2 commits into from
Dec 1, 2021

Conversation

psav
Copy link
Collaborator

@psav psav commented Nov 24, 2021 •
edited
Loading

We may not want to deploy this to ephemeral env - up for discussion

@psav psav added enhancement New feature or request pr-functional-change Will result in a new binary labels Nov 24, 2021
@psav psav added the on hold Waiting for a condition to become true label Nov 30, 2021
kylape
kylape requested changes Nov 30, 2021
View reviewed changes
Copy link
Member

@kylape kylape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put metrics behind feature flag because in ephemeral env it would produce too many labels/timeseries

@psav psav merged commit 6669f3b into master Dec 1, 2021
@psav psav deleted the psav/per_resource_metrics branch December 3, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylape kylape kylape requested changes

Assignees
No one assigned
Labels
enhancement New feature or request on hold Waiting for a condition to become true pr-functional-change Will result in a new binary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psav @kylape